doc: readline.emitKeypressEvents and raw mode#6628
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax added the readline 
arve0 changed the title 
doc/api/readline.md Outdated
Member
jasnell commented May 8, 2016
@nodejs/documentation |
ContributorAuthor
arve0 commented May 8, 2016
Might wanna add a check that the stream is a TTY in the example? if(process.stdin.isTTY){// might not be a TTY if spawned from another node processprocess.stdin.setRawMode(true)} |
doc/api/readline.md Outdated
Member
There was a problem hiding this comment.
“… the stream, if it is a TTY, needs to be…”?
Member
addaleax commented May 12, 2016
@arve0 +1 to adding that check to the example. LGTM apart from that. |
`readline.emitKeypressEvents` needs `stream` to be in raw mode, ref nodejs#6626
ContributorAuthor
arve0 commented May 12, 2016
Updated. |
Contributor
r-52 commented May 12, 2016
LGTM |
addaleax pushed a commit that referenced this pull request May 16, 2016
`readline.emitKeypressEvents` needs `stream` to be in raw mode. PR-URL: #6628Fixes: #6626 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Member
addaleax commented May 16, 2016
Landed in 1ba5a56. Thank you! |
evanlucas pushed a commit that referenced this pull request May 17, 2016
`readline.emitKeypressEvents` needs `stream` to be in raw mode. PR-URL: #6628Fixes: #6626 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
readline.emitKeypressEventsneedsstreamto be in raw mode, fixes#6626