doc: fix exec example in child_process#6660
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
MylesBorins commented May 9, 2016
LGTM |
1 similar comment
Contributor
whitlockjc commented May 9, 2016
LGTM |
mscdex added the child_process 
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: nodejs#6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
ContributorAuthor
evanlucas commented May 13, 2016
Landed in d13b9d3. Thanks! |
evanlucas added a commit that referenced this pull request May 17, 2016
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: #6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: #6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: #6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: #6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: #6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.