test,win: skip addons/load-long-path on WOW64#6675
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Fishrock123 commented May 10, 2016
What kind of system is |
Member
bnoordhuis commented May 10, 2016
LGTM although it's more commonly spelled as "WoW64", I think? @Fishrock123 Windows 32 bits on a Windows 64 bits host. |
ContributorAuthor
orangemocha commented May 10, 2016
I went with the official spelling by Microsoft, I can change it if you feel strongly about it. https://msdn.microsoft.com/en-us/library/windows/desktop/aa384274(v=vs.85).aspx |
Member
bnoordhuis commented May 10, 2016
No strong feelings. |
ContributorAuthor
orangemocha commented May 12, 2016
I'll wait for #6697 to land and adopt the new skip syntax. |
Member
addaleax commented May 24, 2016
@orangemocha#6697 has landed, you should be able to use the new syntax here. |
orangemochaforce-pushed the orangemocha-Node3667 branch from f1d5293 to ec9f8f4CompareContributorAuthor
orangemocha commented May 25, 2016
Updated, thanks! |
Contributor
cjihrig commented May 25, 2016
LGTM |
ContributorAuthor
orangemocha commented May 26, 2016
ContributorAuthor
orangemocha commented May 27, 2016
I am confident that the CI failures on ARM are unrelated to this change. /cc @nodejs/testing https://ci.nodejs.org/job/node-test-binary-arm/2285/RUN_SUBSET=6,label=pi1-raspbian-wheezy/ Landing shortly. |
orangemocha added a commit that referenced this pull request May 27, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
orangemochaforce-pushed the orangemocha-Node3667 branch from ec9f8f4 to 6e2ae8aCompareFishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: nodejs#3667 PR-URL: nodejs#6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Member
gibfahn commented Jul 4, 2016
@orangemocha could this be backported? Still seeing this on 4.4.7. |
orangemocha added a commit to JaneaSystems/node that referenced this pull request Jul 5, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: nodejs#3667 PR-URL: nodejs#6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
2 tasks
ContributorAuthor
orangemocha commented Jul 5, 2016
orangemocha added a commit that referenced this pull request Jul 8, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test,win
Description of change
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable wokaround.
Ref: #3667