test: fix test-debugger-repl-break-in-module#6686
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Fixes the issue for me. LGTM |
Member
bnoordhuis commented May 11, 2016
Is the plan to eventually move this test to test/parallel or test/sequential? |
MemberAuthor
@bnoordhuis I hadn't planned on moving them to |
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files.
MemberAuthor
Trott commented May 11, 2016
Rebased, fixed accidental comment change, force pushed. |
Member
bnoordhuis commented May 11, 2016
LGTM
Agreed. |
MemberAuthor
Trott commented May 13, 2016
MemberAuthor
Trott commented May 13, 2016
Two failures in CI are a known flaky test and a definitely-unrelated test that may also be flaky. Just to be cautious, re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2625/ |
MemberAuthor
Trott commented May 13, 2016
CI still looks good but with a pair of unrelated failures. More caution: https://ci.nodejs.org/job/node-test-pull-request/2626/ |
Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: nodejs#6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MemberAuthor
Trott commented May 13, 2016
Green that time. Landed in 9d445bc. |
evanlucas pushed a commit that referenced this pull request May 17, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test debugger
Description of change
The line number checks in test-debugger-repl-break-in-module were
checking for line numbers that exceed the total number of lines in the
files that were being inspected. Change the checks to match the actual
files.