doc: update "who to cc in issues" chart#6694
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
doc/onboarding-extras.md Outdated
Fishrock123force-pushed the doc/subsystem-teams branch from 0b99265 to 4746b8eCompare
doc/onboarding-extras.md Outdated
Contributor
There was a problem hiding this comment.
s/@mscdex//
I am already in in nodejs/http
Member
There was a problem hiding this comment.
As is @indutny ... I can add @bnoordhuis to it right now also
Fishrock123force-pushed the doc/subsystem-teams branch from 4746b8e to 92c48a9Compare
doc/onboarding-extras.md Outdated
Member
There was a problem hiding this comment.
I have created the nodejs/fs team with these initial members
Fishrock123force-pushed the doc/subsystem-teams branch from 92c48a9 to 2c7251bComparedoc/onboarding-extras.md Outdated
Member
There was a problem hiding this comment.
(we store it as deps/cares)
Hopefully we can use this as part of the bot at some stage?
Member
There was a problem hiding this comment.
I've been thinking we could re-use the bot's logic for resolving PR labels, for /cc-ing as well. Who to /cc for which label could be read from this file.
Contributor
orangemocha commented May 12, 2016
We could add @nodejs/platform-windows for tools/msvs/* (mostly for the MSI). |
Member
Trott commented May 12, 2016
LGTM once the c-ares/http error on line 25 is fixed and nodejs/http is added to line 26 (http-parser). IMO, other nits/comments can be addressed now or in subsequent PRs. Fine by me either way. |
Contributor
ronkorving commented May 17, 2016
Feel free to add me to the |
addaleax added the meta 
Contributor
eljefedelrodeodeljefe commented May 25, 2016
@Fishrock123 ping |
Contributor
MylesBorins commented Jun 6, 2016
@Fishrock123 want me to take this over? |
Fishrock123force-pushed the doc/subsystem-teams branch from 2c7251b to 2e99bbdCompare
ContributorAuthor
Fishrock123 commented Jun 17, 2016
Updated, LGTEveryone? |
Fishrock123force-pushed the doc/subsystem-teams branch from 2e99bbd to 451c1f8CompareContributor
MylesBorins commented Jun 17, 2016
LGTM |
Member
Trott commented Jun 22, 2016
@RReverser Looks like this PR already updates the who-to-cc for buffer to the correct group. |
Member
RReverser commented Jun 22, 2016
@Trott. Great! LGTM. |
Refs: nodejs#6655 PR-URL: nodejs#6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Fishrock123force-pushed the doc/subsystem-teams branch from 451c1f8 to f5cddadCompare
Fishrock123 added a commit that referenced this pull request Jun 27, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
Fishrock123 added a commit that referenced this pull request Jul 5, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
See #6655
@nodejs/collaborators please let us know if you think you should be listed here or not.