process: internal/process/stdio.js cleanup / modernization

[jasnell]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

process (internal)

Description of change

Avoid using deprecated getter syntax plus other miscellaneous updates.

[rvagg]

is configurable: false, enumerable: true the default for __defineGetter__? i.e. this isn't breaking is it?

[jasnell]

ah, right, __defineGetter__ uses configurable: true. Will switch that.

[rvagg]

+0, it's a bit churny and I'm unsure this buys us enough to warrant the churn and if we're going to churn then maybe we should make it even nicer by hoisting those functions out of there.

[jasnell]

hoisting them out and putting them where?

[Fishrock123]

In the file, something seen often times as better practice.

Object.defineProperty(process,'stdout'{get: getStdout})functiongetStdout(){}

Edit: this doesn't seem to gain us anything though? +-0

[jasnell]

If that's the "better practice" then I'd assume it's something we'd promote across core... a quick search shows that it's not (and hasn't been) done that way consistently.

In any case, hoisted the things.

[cjihrig]

Same comment. Churn, but the code changes themselves LGTM.

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/2656/

[jasnell]

CI is green except for an unrelated flaky test.

[jasnell]

Landed in f856234

[MylesBorins]

@jasnell set to don't land.. feel free to change that