lib: replace legacy uses of __defineGetter__#6768
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates those.
jasnell added crypto 
nodejs-github-bot added tls 
MemberAuthor
jasnell commented May 15, 2016
@Trott ... is there an eslint rule that can catch these? |
2 tasks
Member
Trott commented May 15, 2016
Not a pre-existing one, but I've made a custom one: #6774 According to that lint rule, there are two files missed in this PR:
I can do them as part of that PR or you can add them to this one. Doesn't matter to me either way. |
MemberAuthor
jasnell commented May 15, 2016
I have a separate pr that covers the stdio ones. I intentionally did not touch the tests. |
MemberAuthor
jasnell commented May 16, 2016
@Trott ... does this PR LGTY? |
MemberAuthor
jasnell commented May 16, 2016
Member
Trott commented May 16, 2016
LGTM |
jasnell added a commit that referenced this pull request May 17, 2016
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates most of those. PR-URL: #6768 Reviewed-By: Rich Trott <[email protected]>
MemberAuthor
jasnell commented May 17, 2016
Landed in f293d0b |
evanlucas pushed a commit that referenced this pull request May 17, 2016
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates most of those. PR-URL: #6768 Reviewed-By: Rich Trott <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request May 18, 2016
Trott added a commit to Trott/io.js that referenced this pull request May 20, 2016
PR-URL: nodejs#6774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Refs: nodejs#6768
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
PR-URL: #6774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Refs: #6768
Contributor
MylesBorins commented Jun 2, 2016
@jasnell lts? |
rvagg pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Refs: #6768
Contributor
Fishrock123 commented Jun 2, 2016
@thealphanerd Little value; I wouldn't bother. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
crypto, readline, internal
Description of change
Minor clean up. There are still some places in core that use the legacy
__defineGetter__syntax. This updates those.