tools: print stderr on bad test.py vmArch check#6786
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
addaleax commented May 16, 2016
LGTM |
1 similar comment
Member
bnoordhuis commented May 19, 2016
LGTM |
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: nodejs#6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fishrock123force-pushed the print-stderr-on-test.py-fail branch from 524e413 to 4babe65CompareFishrock123 added a commit that referenced this pull request May 23, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Contributor
MylesBorins commented Jun 3, 2016
@Fishrock123 lts? |
ContributorAuthor
Fishrock123 commented Jun 3, 2016
@thealphanerd Wouldn't be a bad idea, we're unlikely to encounter it's usefulness there, but in the event we do, well, you'd have to manually put this in to see what's going on. Otherwise effects nothing, not even the CI. |
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: #6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools,test
Description of change
This makes it so you can see why the check fails if it does.
Typically that sort of thing can happen if you are modifying
bootstrapping or process. (Which I seem to do a lot.)
Note: running the CI here is pointless because this isn't triggerable via CI..