test: improve debug-break-on-uncaught reliability

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

test debugger

Description of change

Move test-debug-break-on-uncaught from debugger directory to
sequential so that it gets exercised by make test and via the
continuous integration server for the project.

Removed unnecessary port number modification that is probable source of
unreliability on CI.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2669/

[jasnell]

LGTM if CI is green.

[claudiorodriguez]

Test is failing on several platforms with this:

not ok 1116 sequential/test-debug-break-on-uncaught # # assert.js:90 # throw new assert.AssertionError({# ^ # AssertionError: debugger did not pause on exception # at assertHasPaused (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1204-64/test/sequential/test-debug-break-on-uncaught.js:91:12) # at tryOnTimeout (timers.js:224:11) # at Timer.listOnTimeout (timers.js:198:5) # **[ global.js ]** # **[ timeout.js ]** 

[Trott]

CI again to see if platforms are failing consistently or not: https://ci.nodejs.org/job/node-test-pull-request/2718/

[Trott]

The use of setTimeout() seemed suspicious so I refactored the test to check what was going on a bit more carefully, ran another CI, and sure enough...

https://ci.nodejs.org/job/node-test-commit-linux/3463/nodes=ubuntu1404-64/console

not ok 1121 sequential/test-debug-break-on-uncaught # # assert.js:90 # throw new assert.AssertionError({# ^ # AssertionError: no exceptions thrown, race condition in test? # at assertHasPaused (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/sequential/test-debug-break-on-uncaught.js:91:5) # at tryOnTimeout (timers.js:224:11) # at Timer.listOnTimeout (timers.js:198:5) # **[ global.js ]** # **[ timeout.js ]** --- duration_ms: 1.10 

[Trott]

The latest change makes stuff better but still lots of fail. I'm going to move it back to test/debugger where it won't bother anyone but leave the improvements in case someone else wants to pick it up...

[Trott]

Squashed and force pushed. PTAL.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2721/

[bnoordhuis]

Assumes that lines correspond with data events. I'd concatenate the output and scan that.

[Trott]

@bnoordhuis True. Fixed.

[bnoordhuis]

LGTM with a suggestion.

[claudiorodriguez]

LGTM

[Trott]

implemented @bnoordhuis suggestion...onward to CI: https://ci.nodejs.org/job/node-test-pull-request/2755/

[bnoordhuis]

Still LGTM. Another java.nio.file.DirectoryNotEmptyException on vcbt2015.

/cc @nodejs/build - known issue? Happened several times yesterday, too.

[Trott]

Landed in ff00a48

[MylesBorins]

@Trott lts?

[Trott]

@thealphanerd Yes, if it lands cleanly.