doc: add added: information for punycode#6805
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
36 tasks
Member
addaleax commented May 17, 2016
LGTM, thank you for the work here! |
Member
jasnell commented May 17, 2016
LGTM but I'd like @bnoordhuis to verify/doublecheck the versions on this one if possible |
doc/api/punycode.md Outdated
ContributorAuthor
There was a problem hiding this comment.
@bnoordhuis You are right. I'll fix it right away. I was misled by the punycode doc.
[Punycode.js][] is bundled with Node.js v0.6.2+.I'll fix it, too.
ContributorAuthor
There was a problem hiding this comment.
@bnoordhuis All fixed. Thank you very much!
firedfoxforce-pushed the add-added-infomation-for-punycode branch from ac1906e to 11c71feCompareContributorAuthor
firedfox commented May 18, 2016
Sorry for making so many mistakes. Obviously I should rely on binaries but not docs. I'm working on a script to check the versions by calling methods within all nodejs binaries, from v0.1.14 to v6.2.0. |
doc/api/punycode.md Outdated
Member
There was a problem hiding this comment.
So, this should be v0.5.1. The first punycode.js was https://github.com/bnoordhuis/punycode.js and was later replaced with https://github.com/bestiejs/punycode.js.
firedfoxforce-pushed the add-added-infomation-for-punycode branch from 11c71fe to edf1b4cCompare
Member
bnoordhuis commented May 19, 2016
Thanks Daniel, landed in b90c52e. |
bnoordhuis pushed a commit that referenced this pull request May 19, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
PR-URL: nodejs#6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578