test: fix flaky test-stdout-close-catch#6808
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added stream 
Contributor
cjihrig commented May 17, 2016
LGTM |
MemberAuthor
santigimeno commented May 17, 2016
Member
jasnell commented May 17, 2016
LGTM |
1 similar comment
Contributor
r-52 commented May 17, 2016
LGTM |
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: nodejs#6791 PR-URL: nodejs#6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MemberAuthor
santigimeno commented May 18, 2016
CI is green. Landing now. |
MemberAuthor
santigimeno commented May 18, 2016
Landed in 89460f1 |
MemberAuthor
santigimeno commented May 18, 2016
Thanks |
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: #6791 PR-URL: #6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: #6791 PR-URL: #6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: #6791 PR-URL: #6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: #6791 PR-URL: #6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: #6791 PR-URL: #6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Make sure that
catch-stdout-errorhas written data before thedestination process exits.
Fixes: #6791
Stress test on
FreeBSDwithout this change fails: https://ci.nodejs.org/job/node-stress-single-test/727/Stress test with this change succeeds: https://ci.nodejs.org/job/node-stress-single-test/731/