doc: general improvements to vm.md copy#6827
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jasnell added doc jasnell changed the title 
doc/api/vm.md Outdated
There was a problem hiding this comment.
an API? It should have been APIs right?
There was a problem hiding this comment.
Either works but will switch it to the plural form, sounds better.
jasnell commented May 18, 2016
Thank you all for the quick review. I absolutely love it that I can open a draft like this and open my inbox in the morning and find comments on it already :-) |
jasnell commented May 18, 2016
Updated! PTAL |
doc/api/vm.md Outdated
There was a problem hiding this comment.
grr... my dang muscle memory on typing that stupid ' every time I want to type its it's freaking annoying...
bnoordhuis commented May 18, 2016
Suggestion: replace "any stack traces produced from this script" with "stack traced produced by this script", it's a little more succinct. LGTM (with grammar nit) either way, though. |
jasnell commented May 18, 2016
Updated to address the nits. Thank you for the review! |
General improvements to vm module documentation
General improvements to vm module documentation PR-URL: #6827 Reviewed-By: Ben Noordhuis <[email protected]>
jasnell commented May 20, 2016
Landed in baeed8b |
General improvements to vm module documentation PR-URL: #6827 Reviewed-By: Ben Noordhuis <[email protected]>
General improvements to vm module documentation PR-URL: #6827 Reviewed-By: Ben Noordhuis <[email protected]>
5 participants
Checklist
Affected core subsystem(s)
doc (vm)
Description of change
General improvements to vm module documentation
/cc @nodejs/documentation @bnoordhuis