Skip to content

Conversation

@mhdawson
Copy link
Member

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

fs

Description of change

Noticed we don't mention how fswatch is implemented for AIX like
we do on other platforms, adding

Info is provided on for the other OS's. Add similar level of info for AIX.
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 18, 2016
@mhdawsonmhdawson self-assigned this May 18, 2016
@cjihrig
Copy link
Contributor

LGTM

1 similar comment
@santigimeno
Copy link
Member

LGTM

* On OS X, this uses `kqueue` for files and 'FSEvents' for directories.
* On SunOS systems (including Solaris and SmartOS), this uses `event ports`.
* On Windows systems, this feature depends on `ReadDirectoryChangesW`.
* On Aix systems, this feature depends on `AHAFS`, which must be enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. it would be excellent if these were links (e.g. if kqueue' was a link to more information onkqueue,event portswas a link to more information on that,AHAFS` was a link to more information on that, etc). That could be done in a separate PR tho.

@jasnell
Copy link
Member

Small nit but LGTM

@mhdawson
Copy link
MemberAuthor

@jasnell, good idea, I'll land this and put it on my queue to submit a new one with the links added for all.

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label May 18, 2016
mhdawson added a commit that referenced this pull request May 27, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@mhdawson
Copy link
MemberAuthor

Landed as 8af25a3

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: nodejs#6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@mhdawsonmhdawson deleted the fsdoc branch March 15, 2017 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@mhdawson@cjihrig@santigimeno@jasnell@mscdex@MylesBorins@nodejs-github-bot