src: Remove unused Dtrace probes.#694
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removed DTRACE_NET_SOCKET_READ and DTRACE_NET_SOCKET_WRITE as they were never called from within the source code.
ContributorAuthor
GlenTiki commented Feb 2, 2015
This will need to be tested by someone who can build with dtrace enabled, please. This resolves #692 |
bnoordhuis pushed a commit that referenced this pull request Feb 2, 2015
Removed DTRACE_NET_SOCKET_READ and DTRACE_NET_SOCKET_WRITE as they were never called from within the source code. PR-URL: #694 Reviewed-By: Ben Noordhuis <[email protected]>
Member
bnoordhuis commented Feb 2, 2015
Thanks Glen, LGTM and I can confirm that --with-dtrace still works on OS X. Landed in d75fecf with an amended Author field (used your full name.) Thanks again! |
ContributorAuthor
GlenTiki commented Feb 2, 2015
Awesome! Happy to help. :) |
Member
rvagg commented Feb 3, 2015
pls see #698 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed DTRACE_NET_SOCKET_READ and DTRACE_NET_SOCKET_WRITE
as they were never called from within the source code.