Skip to content

Conversation

@julianduque
Copy link
Contributor

@julianduquejulianduque commented May 26, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, path

Description of change

Add added: information for path.

Got the information from git history mostly, I ignored previous path
methods attached to node.path (pre v0.1.16).

Ref: #6578

Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Ref: nodejs#6578
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 26, 2016
@mscdexmscdex added the path Issues and PRs related to the path subsystem. label May 26, 2016
@addaleax
Copy link
Member

LGTM and thanks for this!

@jasnell
Copy link
Member

LGTM
@mscdex and @bnoordhuis ... do the versions look correct?

@julianduque
Copy link
ContributorAuthor

Any objection to merge this?

jasnell pushed a commit that referenced this pull request Jun 3, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in bed44c9

@jasnelljasnell closed this Jun 3, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@evanlucasevanlucas mentioned this pull request Jun 16, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: nodejs#6578 PR-URL: nodejs#6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Got the information from git history mostly, I ignored previous path methods attached to `node.path` (pre v0.1.16). Refs: #6578 PR-URL: #6985 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.pathIssues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@julianduque@addaleax@jasnell@mscdex@MylesBorins@nodejs-github-bot