Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
doc: add added: information for net#7038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
doc/api/net.md Outdated
| ## Class: net.Server | ||
| <!-- YAML | ||
| added: v0.7.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? The docs change in which it was introduced seems to be in 499c615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap you are right. thanks
addaleax commented Jun 1, 2016
Generally looking good, with a few comments… really appreciate the hard work behind this! |
italoacasas commented Jun 1, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
tomorrow I'm going to check |
addaleax commented Jun 2, 2016
LGTM |
addaleax commented Jun 3, 2016
Merged, thanks for the effort you put into this! |
Ref: #6578 PR-URL: #7038 Reviewed-By: Anna Henningsen <[email protected]>
Ref: nodejs#6578 PR-URL: nodejs#7038 Reviewed-By: Anna Henningsen <[email protected]>
Ref: #6578 PR-URL: #7038 Reviewed-By: Anna Henningsen <[email protected]>
Ref: #6578 PR-URL: #7038 Reviewed-By: Anna Henningsen <[email protected]>
Ref: #6578 PR-URL: #7038 Reviewed-By: Anna Henningsen <[email protected]>
Ref: #6578 PR-URL: #7038 Reviewed-By: Anna Henningsen <[email protected]>
Checklist
Affected core subsystem(s)
Description of change
Add
added:information fornetRef: #6578