deps: update v8_inspector#7118
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Pick the latest v8_inspector [1] with: * V8 5.1 compatibility * Modify parse builder templates to make coverity happy * The whitespace differences in the jinja2 sub-dependency do exist upstream. I am not sure how I missed them in the original import (ed2eac). [1] pavelfeldman/v8_inspector@3b56732
nodejs-github-bot added the inspector 
Member
addaleax commented Jun 3, 2016
LGTM |
Contributor
MylesBorins commented Jun 3, 2016
ci: https://ci.nodejs.org/job/node-test-pull-request/2910/ @ofrobots it would be awesome to get some basic tests in for the debugger. I'd be up for working on some to make the process of landing these updates clearer. Would we be able to draw on any of the v8 or chomium tests? |
Contributor
cjihrig commented Jun 3, 2016
LGTM |
Member
jasnell commented Jun 3, 2016
LGTM if CI is green |
Contributor
MylesBorins commented Jun 3, 2016
arm failures appear to be infra related LGTM |
Member
addaleax commented Jun 3, 2016
@ofrobots’ CI is green, fwiw. |
| DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
Member
There was a problem hiding this comment.
Can you undo the LF -> CRLF changes in this file?
EDIT: Or does this come verbatim from upstream?
ContributorAuthor
There was a problem hiding this comment.
This did come verbatim from upstream. The difference shows up, as you guessed, because we land with --whitespace=fix
Member
bnoordhuis commented Jun 3, 2016
LGTM. I usually land patches with |
Member
targos commented Jun 3, 2016
LGTM |
targos pushed a commit that referenced this pull request Jun 3, 2016
Pick the latest v8_inspector [1] with: * V8 5.1 compatibility * Modify parse builder templates to make coverity happy * The whitespace differences in the jinja2 sub-dependency do exist upstream. I am not sure how I missed them in the original import (ed2eac). [1] pavelfeldman/v8_inspector@3b56732 PR-URL: #7118 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
targos commented Jun 3, 2016
Landed in 8847777 |
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Pick the latest v8_inspector [1] with: * V8 5.1 compatibility * Modify parse builder templates to make coverity happy * The whitespace differences in the jinja2 sub-dependency do exist upstream. I am not sure how I missed them in the original import (ed2eac). [1] pavelfeldman/v8_inspector@3b56732 PR-URL: #7118 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
deps
Description of change
Pick the latest v8_inspector [1].
upstream. I am not sure how I missed them in the original import
(ed2eacb).
[1] pavelfeldman/v8_inspector@3b56732
/cc @targos, @pavelfeldman, @bnoordhuis
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/2909/