cluster: don't send messages if no IPC channel#7132
Merged
+21 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the cluster 
MemberAuthor
santigimeno commented Jun 3, 2016
Member
jasnell commented Jun 3, 2016
LGTM |
lib/cluster.js Outdated
Contributor
There was a problem hiding this comment.
The diff would be a little less noisy if you did:
if(!proc.connected)returnfalse;
Contributor
cjihrig commented Jun 3, 2016
LGTM, I just hope there aren't scenarios I'm not thinking of where this could swallow valid errors. |
santigimenoforce-pushed the cluster_process_disconnect branch from f54ce27 to 6e838e9CompareMemberAuthor
santigimeno commented Jun 5, 2016
Updated. Thanks! |
MemberAuthor
santigimeno commented Jun 5, 2016
santigimenoforce-pushed the cluster_process_disconnect branch 2 times, most recently from 381d514 to de6ff56CompareMemberAuthor
santigimeno commented Jun 8, 2016
Rebased to current master. One last CI run: https://ci.nodejs.org/job/node-test-pull-request/2957/ |
MemberAuthor
santigimeno commented Jun 8, 2016
All is green. Landing |
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: nodejs#7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
santigimenoforce-pushed the cluster_process_disconnect branch from de6ff56 to 8c53d2fCompareMemberAuthor
santigimeno commented Jun 8, 2016
Landed in 8c53d2f. Thanks! |
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Contributor
MylesBorins commented Jul 11, 2016
@santigimeno lts? |
MemberAuthor
santigimeno commented Jul 12, 2016
@thealphanerd Yes, I would think so. |
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
cluster
Description of change
Avoid sending messages if the IPC channel is already disconnected.
It avoids undesired errors when calling
process.disconnectwhen thereare still pending IPC messages.
/cc @cjihrig@bnoordhuis