benchmark: fix child-process-exec-stdout on win#7178
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows.
nodejs-github-bot added the benchmark 
Contributor
cc @nodejs/platform-windows |
mscdex added child_process 
Contributor
mscdex commented Jun 6, 2016
/cc @Trott |
Member
Trott commented Jun 6, 2016
LGTM |
1 similar comment
Contributor
orangemocha commented Jun 9, 2016
LGTM |
orangemocha pushed a commit that referenced this pull request Jun 10, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Contributor
orangemocha commented Jun 10, 2016
CI is green: https://ci.nodejs.org/job/node-test-pull-request/2974/ Landed in 5386b23. Thanks! |
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Merged
Contributor
@orangemocha should this be landed in lts? |
Contributor
orangemocha commented Jul 12, 2016
@thealphanerd I would say yes, though it's not critical. |
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
benchmark
Description of change
This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.
cc @nodejs/benchmarking