doc: remove cluster.setupMaster() myth#7179
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
jasnell commented Jun 6, 2016
LGTM |
Contributor
claudiorodriguez commented Jun 6, 2016
LGTM |
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: nodejs#7156 PR-URL: nodejs#7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
cluster.setupMaster() can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation. Fixes: #7156 PR-URL: #7179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
cluster.setupMaster()can be called more than once. Core even has tests for this functionality. This commit removes an incorrect statement to the contrary from the documentation.Closes#7156