Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jun 8, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc http

Description of change

Add documentation for http.IncomingMessage.prototype.destroy().

Fixes: #4226

@TrottTrott added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Jun 8, 2016
doc/api/http.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fired/emitted

@jasnell
Copy link
Member

LGTM with a nit

doc/api/http.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the . from .destroy()

@cjihrig
Copy link
Contributor

LGTM, also with a nit.

Trott added 3 commits June 11, 2016 20:09
Trott added a commit to Trott/io.js that referenced this pull request Jun 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: nodejs#7237Fixes: nodejs#4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
@Trott
Copy link
MemberAuthor

Landed in 4f2aec3

@TrottTrott closed this Jun 12, 2016
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: #7237Fixes: #4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
@evanlucasevanlucas mentioned this pull request Jun 16, 2016
@MylesBorins
Copy link
Contributor

@Trott is this relevant to v4.x?

@Trott
Copy link
MemberAuthor

@thealphanerd Yes.

@addaleaxaddaleax mentioned this pull request Jul 12, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: nodejs#7237Fixes: nodejs#4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: #7237Fixes: #4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: #7237Fixes: #4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: #7237Fixes: #4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Add documentation for `http.IncomingMessage.prototype.destroy()`. PR-URL: #7237Fixes: #4226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
@TrottTrott deleted the destroy branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is IncomingMessage.destroy method not documented?

4 participants

@Trott@jasnell@cjihrig@MylesBorins