benchmark: add benchmark for url.format()#7250
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added url 
MemberAuthor
Trott commented Jun 11, 2016
CI: https://ci.nodejs.org/job/node-test-pull-request/2987/ (Although only thing that matters is linting because benchmark code isn't exercised in CI...) |
Contributor
LGTM @Trott FWIW you can start just a linter job using |
Trott added a commit to Trott/io.js that referenced this pull request Jun 13, 2016
PR-URL: nodejs#7250 Reviewed-By: Brian White <[email protected]>
MemberAuthor
Trott commented Jun 13, 2016
Landed in 08ea9ee |
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7250 Reviewed-By: Brian White <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark url
Description of change
/cc @nodejs/benchmarking @mscdex@bnoordhuis
Wrote this to check on impact of template strings and
startsWith()in #7234. Putting it in with the other benchmarks so that others can benefit from it and so that more knowledgable people can check that there isn't an error that invalidates the entire benchmark. It only has use cases that I'm specifically testing right now, but others can be easily added as needed or pro-actively.Refs: #7234