src: alias BINARY to LATIN1#7284
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnoordhuis added c++ 
Contributor
thefourtheye commented Jun 13, 2016
LGTM. We are redefining |
MemberAuthor
bnoordhuis commented Jun 13, 2016
|
Contributor
cjihrig commented Jun 13, 2016
LGTM |
1 similar comment
Member
addaleax commented Jun 13, 2016
LGTM |
Merged
Contributor
Fishrock123 commented Jun 17, 2016
Needs to land for #7323 |
4 tasks
MemberAuthor
bnoordhuis commented Jun 17, 2016
This shouldn't land in any of the release lines. I've added the tags. |
MemberAuthor
bnoordhuis commented Jun 17, 2016
New CI, previous one seems to have been cancelled: https://ci.nodejs.org/job/node-test-pull-request/3013/ |
Contributor
cjihrig commented Jun 17, 2016
CI was good minus a seemingly unrelated failure. |
Make BINARY an alias for LATIN1 rather than a distinct enum value. PR-URL: nodejs#7284 Refs: nodejs#7262 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuisforce-pushed the alias-binary-to-latin1 branch from 7b40780 to a92089bCompare
addaleax pushed a commit to addaleax/node that referenced this pull request Aug 8, 2016
Make BINARY an alias for LATIN1 rather than a distinct enum value. PR-URL: nodejs#7284 Refs: nodejs#7262 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make BINARY an alias for LATIN1 rather than a distinct enum value.
Refs: #7262
CI: https://ci.nodejs.org/job/node-test-pull-request/2993/