Skip to content

Conversation

@cjihrig
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

This commit corrects the clustermessage event signature.

Fixes: #5764

This commit corrects the cluster message event signature. Fixes: nodejs#5764
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 14, 2016
@mscdexmscdex added cluster Issues and PRs related to the cluster subsystem. v4.x labels Jun 14, 2016
@mscdex
Copy link
Contributor

mscdex commented Jun 14, 2016

LGTM.

On a semi-related note, it looks like the documentation for the worker's message event isn't documented correctly in all versions of the documentation (including master). It's missing a handle parameter after the actual message object parameter. The master's message event already has this parameter properly documented however.

@cjihrigcjihrig mentioned this pull request Jun 15, 2016
2 tasks
@cjihrigcjihrig merged commit 47f82cd into nodejs:v4.x-stagingJun 15, 2016
@cjihrigcjihrig deleted the docs branch June 15, 2016 14:32
cjihrig added a commit to cjihrig/node that referenced this pull request Jun 17, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: nodejs#7297 PR-URL: nodejs#7309 Reviewed-By: Brian White <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
This commit corrects the cluster message event signature. Fixes: #5764 PR-URL: #7297 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
This commit corrects the cluster message event signature. Fixes: #5764 PR-URL: #7297 Reviewed-By: Brian White <[email protected]>
evanlucas pushed a commit that referenced this pull request Jun 27, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This commit adds the missing handle argument to the cluster worker 'message' event. It also adds a link to the process 'message' event for reference. Refs: #7297 PR-URL: #7309 Reviewed-By: Brian White <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clusterIssues and PRs related to the cluster subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig@mscdex@MylesBorins@nodejs-github-bot