deps: switch to upstream v8_inspector#7302
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
rvagg commented Jun 15, 2016
sgtm https://ci.nodejs.org/job/node-test-commit/3749/ Is @nodejs/v8 going to be good to call for review on changes here or should we consider v8_inspector a separate concern and perhaps start calling on |
Member
indutny commented Jun 15, 2016
Oh... this tightens our dependency on Python, though this PR SGTM. LGTM, if CI is green and @bnoordhuis is happy. |
Member
rvagg commented Jun 15, 2016
Build failures on older GCC / Linux will need looking at https://ci.nodejs.org/job/node-test-commit-linux/3808/ |
ContributorAuthor
ofrobots commented Jun 15, 2016
Those are due to Python 2.6 on the CentOS machines; this CL fixes things upstream: https://codereview.chromium.org/2066423002/. Once the CL lands, I will update this PR. |
ofrobotsforce-pushed the inspector_upstream branch from 170b375 to b47e965CompareContributorAuthor
ofrobots commented Jun 16, 2016
ContributorAuthor
ofrobots commented Jun 16, 2016
CI is green. @bnoordhuis: ready for your review. |
Member
bnoordhuis commented Jun 16, 2016
LGTM at a glance. |
This change picks up v8_inspector directly from the upstream chromium repository [1]; dropping the intermediate repository. The upstream code has been refactored substantially to make it easy to share code without adaptation with Node.js. The deps/v8_inspector directory is now simply a gathering of dependencies: * platform/v8_inspector: vendored from [2]. * platform/inspector_protocol: vendored from [3]. * deps/jinja2: vendored from [4]. * deps/markupsafe: vendored from [5]. [1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform [2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector [3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol [4]: https://github.com/mitsuhiko/jinja2 [5]: https://github.com/mitsuhiko/markupsafe PR-URL: nodejs#7302 Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
ofrobotsforce-pushed the inspector_upstream branch from b47e965 to 44b9154Compare
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
This change picks up v8_inspector directly from the upstream chromium repository [1]; dropping the intermediate repository. The upstream code has been refactored substantially to make it easy to share code without adaptation with Node.js. The deps/v8_inspector directory is now simply a gathering of dependencies: * platform/v8_inspector: vendored from [2]. * platform/inspector_protocol: vendored from [3]. * deps/jinja2: vendored from [4]. * deps/markupsafe: vendored from [5]. [1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform [2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector [3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol [4]: https://github.com/mitsuhiko/jinja2 [5]: https://github.com/mitsuhiko/markupsafe PR-URL: #7302 Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps: v8_inspector
Description of change
This change picks up v8_inspector directly from the upstream chromium
repository 1; dropping the intermediate repository. The upstream
code has been refactored substantially to make it easy to share code
without adaptation with Node.js.
The deps/v8_inspector directory is now simply a gathering of
dependencies:
R=@bnoordhuis
/cc @pavelfeldman@eugeneo