Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: fix exec stdout & stderr default type in child_process#7361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sartrey commented Jun 22, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
sartrey commented Jun 22, 2016
doc/api/child_process.md Outdated
| the output as UTF-8 and pass strings to the callback. The `encoding` option | ||
| can be used to specify the character encoding used to decode the stdout and | ||
| stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to | ||
| stderr output. If `encoding` is `'buffer'` (or not a valid Buffer encoding), `Buffer` objects will be passed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should say something like:
If
encodingis'buffer', or an unrecognized character encoding,Bufferobjects will be passed to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please wrap lines at 80 characters.
sartrey commented Jun 23, 2016
@cjihrig I will edit these lines. |
doc/api/child_process.md Outdated
| can be used to specify the character encoding used to decode the stdout and | ||
| stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to | ||
| the callback instead. | ||
| stderr output. If `encoding` is `'buffer'`, or an unrecognized character encoding, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a quick check, it seems like these lines are still > 80 characters.
sartrey commented Jun 24, 2016
@cjihrig Sorry for my poor English, here is my true meaning in Chinese 我在文档的前半部分看到一些行也超过了80字符, 如果我必须精确遵循80字符,请告诉我,我会修改的。 |
cjihrig commented Jun 24, 2016
Please wrap them at 80 characters or less. There are some other longer lines, but they shouldn't be that way (no need to change the other ones in this PR though). |
sartrey commented Jun 25, 2016
@cjihrig Please review this new commit. |
cjihrig commented Jun 27, 2016
LGTM |
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
cjihrig commented Jun 27, 2016
Thanks! Landed in 926707f. |
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Clarify how the encoding option interacts with the data type of child process stdout and stderr. Fixes: #6666 PR-URL: #7361 Reviewed-By: Colin Ihrig <[email protected]>
Checklist
Affected core subsystem(s)
Description of change
add words in child_process docs about invalid Buffer encoding leading to a default buffer output