Skip to content

Conversation

@lance
Copy link
Member

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add @lance to collaborator list on README.md

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 24, 2016
@Trott
Copy link
Member

Nit: no period at the end of the first commit line

@addaleax
Copy link
Member

LGTM with @Trott’s nit, welcome!

@Trott
Copy link
Member

LGTM with a nit

@cjihrig
Copy link
Contributor

LGTM

lance added a commit that referenced this pull request Jun 24, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
@lance
Copy link
MemberAuthor

Landed in 0b9e135

@lancelance closed this Jun 24, 2016
@lancelance deleted the add-lance-to-readme branch June 24, 2016 17:31
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
@Fishrock123Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
@Fishrock123Fishrock123 mentioned this pull request Jul 5, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7407
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lance@Trott@addaleax@cjihrig@MylesBorins@nodejs-github-bot