debug: use arrow functions for lexical this#7415
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented Jun 25, 2016
Contributor
cjihrig commented Jun 27, 2016
LGTM |
2 similar comments
Member
jasnell commented Jun 27, 2016
LGTM |
Contributor
mscdex commented Jun 27, 2016
LGTM |
Member
jasnell commented Aug 18, 2016
New CI since it appears this fell through the cracks: https://ci.nodejs.org/job/node-test-pull-request/3742/ |
jasnell pushed a commit that referenced this pull request Aug 18, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Member
jasnell commented Aug 18, 2016
Landed in a9387db! |
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Refs: #7414 PR-URL: #7415 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
debug
( specifically:
lib/_debug_agent.js)Description of change
Use arrow functions to replace 3x
var self = this; ... function(){self.whatever() }pattern.See #7414 for more details.