Upgrade cpplint#7462
Merged
Upgrade cpplint #7462
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
This commit disables the build/include, build/include_alpha, build/include_order and legal/copyright warnings again. PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
This commit reimplements commit 7b45163 ("tools: add tap output to cpplint") on top of the upgraded copy of cpplint. PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>This reapplies commit a493dab ("cpplint: make it possible to run outside git repo") from September 2015, this time with a proper status line. PR-URL: nodejs#7462 Refs: nodejs#2693 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
Obsoleted by the recent cpplint upgrade. PR-URL: nodejs#7462 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis added c++ 
nodejs-github-bot added the inspector 
src/node_version.h Outdated
Contributor
There was a problem hiding this comment.
heh. this rule was the first thing I spent time fixing on my initial attempt. wish I had taken the time to see how many lines of code were affected first.
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Obsoleted by the recent cpplint upgrade. PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This commit disables the build/include, build/include_alpha, build/include_order and legal/copyright warnings again. PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This commit reimplements commit 7b45163 ("tools: add tap output to cpplint") on top of the upgraded copy of cpplint. PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
This reapplies commit a493dab ("cpplint: make it possible to run outside git repo") from September 2015, this time with a proper status line. PR-URL: #7462 Refs: #2693 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Obsoleted by the recent cpplint upgrade. PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#7444.
I dropped our custom whitespace/if-one-line rule because I don't think it's all that great and didn't feel like reimplementing it.
R=@trevnorris?
CI: https://ci.nodejs.org/job/node-test-pull-request/3109/