Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jul 4, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc net http

Description of change

@TrottTrott added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jul 4, 2016
@Trott
Copy link
MemberAuthor

Trott commented Jul 4, 2016

@nodejs/documentation

@addaleax
Copy link
Member

LGTM but you might want to keep an eye on #7137 which addresses all of the net changes here (although in a slightly different way).

@Trott
Copy link
MemberAuthor

Trott commented Jul 7, 2016

Landing the http stuff only so as not to step on the net changes in #7137.

Trott added a commit to Trott/io.js that referenced this pull request Jul 7, 2016
@Trott
Copy link
MemberAuthor

Trott commented Jul 7, 2016

Landed in 0f3149e

@TrottTrott closed this Jul 7, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@evanlucasevanlucas mentioned this pull request Jul 18, 2016
@TrottTrott deleted the netcomma branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.netIssues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott@addaleax@MylesBorins