build: Fix compile failure in backtrace_posix.cc#7544
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix compile failure in backtrace_posix.c on AIX
nodejs-github-bot added the c++ 
MemberAuthor
mhdawson commented Jul 5, 2016
MemberAuthor
mhdawson commented Jul 5, 2016
Contributor
cjihrig commented Jul 5, 2016
LGTM |
MemberAuthor
mhdawson commented Jul 5, 2016
Going to land this once the CI run completes since it fixes a build break and the change is small and have one LGTM altready. |
Member
bnoordhuis commented Jul 5, 2016
LGTM |
1 similar comment
Contributor
mscdex commented Jul 5, 2016
LGTM |
MemberAuthor
mhdawson commented Jul 5, 2016
CI is good landing |
MemberAuthor
mhdawson commented Jul 5, 2016
Landed as 95a3c8f |
mhdawson added a commit that referenced this pull request Jul 5, 2016
Fix compile failure in backtrace_posix.c on AIX Fixes: #7539 PR-URL: #7544 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 6, 2016
Fix compile failure in backtrace_posix.c on AIX Fixes: #7539 PR-URL: #7544 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
Contributor
MylesBorins commented Jul 12, 2016
@mhdawson lts? |
Contributor
MylesBorins commented Jul 14, 2016
needs to be backported if #6734 is backported |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
core
Description of change
Fix compile failure in backtrace_posix.c on AIX introduced by #6734