deps: back-port d721121 from v8 upstream (v6.x)#7633
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
indutny commented Jul 9, 2016
Rubber-stamp LGTM |
Member
targos commented Jul 9, 2016
LGTM |
MemberAuthor
V8 CI once more, previous run seems to have been aborted: https://ci.nodejs.org/job/node-test-commit-v8-linux/210/ EDIT: https://ci.nodejs.org/job/node-test-commit-v8-linux/211/ - rebasing onto v6.x from the CI's web UI doesn't seem to work. |
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{nodejs#35346} Fixes: nodejs#7454
bnoordhuisforce-pushed the fix7454-v8-5.0 branch 2 times, most recently from dafdcb3 to c10ade9Comparebnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Jul 18, 2016
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{nodejs#35346} Fixes: nodejs#7454 PR-URL: nodejs#7633 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MemberAuthor
bnoordhuis commented Jul 18, 2016
Landed in c10ade9. |
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{#35346} Fixes: #7454 PR-URL: #7633 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Jul 22, 2016
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{#35346} Fixes: nodejs/node#7454 PR-URL: nodejs/node#7633 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #7454
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/3231/
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/188/