Skip to content

Conversation

@addaleax
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@addaleaxaddaleax added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jul 9, 2016
@addaleax
Copy link
MemberAuthor

/cc @nodejs/documentation

@jasnell
Copy link
Member

LGTM.
ping @cjihrig@trevnorris

@cjihrig
Copy link
Contributor

A lot of these are before my time working on core. I'll offer a rubber stamp LGTM, and we can fix any of these that may be wrong at a later time.

jasnell pushed a commit that referenced this pull request Aug 9, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

Landed in c628982

@jasnelljasnell closed this Aug 9, 2016
@cjihrigcjihrig mentioned this pull request Aug 10, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
@MylesBorins
Copy link
Contributor

not landing cleanly @addaleax manual backport?

@addaleaxaddaleax deleted the add-added-cluster branch September 30, 2016 20:13
addaleax added a commit to addaleax/node that referenced this pull request Sep 30, 2016
Ref: nodejs#6578 PR-URL: nodejs#7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Ref: #6578 PR-URL: #7640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clusterIssues and PRs related to the cluster subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax@jasnell@cjihrig@MylesBorins