test: add common.rootDir#7685
Merged
test: add common.rootDir #7685
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added test 
nodejs-github-bot removed the child_process 
Contributor
silverwind commented Jul 12, 2016
LGTM |
Member
santigimeno commented Jul 13, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: nodejs#7685 Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jul 18, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: #7685 Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: #7685 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: #7685 Reviewed-By: Roman Reiss <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: #7685 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: #7685 Reviewed-By: Roman Reiss <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
A few of the child process tests can be simplified by computing
the OS specific root directory in common and then accessing that
value.