src: clean up string_search#7686
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added c++ mscdexforce-pushed the v4.x-string-search-lint branch from 2406c7d to fd3c95eComparemscdexforce-pushed the v4.x-string-search-lint branch from fd3c95e to 839ad6cCompare
Member
addaleax commented Jul 12, 2016
LGTM |
Contributor
MylesBorins commented Jul 12, 2016
@mscdex this is going to need a rebase, thanks for the patience |
This commit removes some unnecessary signed checks on unsigned variables. PR-URL: nodejs#7174 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
mscdexforce-pushed the v4.x-string-search-lint branch from 839ad6c to 13abb8dCompare
ContributorAuthor
mscdex commented Jul 12, 2016
Yeah I don't know how that happened. It's fixed now anyway. |
Contributor
MylesBorins commented Jul 14, 2016
landed in 6519e02 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #7174. A couple of the changes were not valid for v4.x.