Skip to content

Conversation

@Trott
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

meta

Description of change

Update some outdated material. Provide some minor fixes. Wrap to 80
characters.

@nodejs/ctc

@TrottTrott added the meta Issues and PRs related to the general management of the project. label Jul 13, 2016
GOVERNANCE.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be streamed?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes thanks, will fix!

@rvagg
Copy link
Member

aye, lgtm

@bnoordhuis
Copy link
Member

LGTM

GOVERNANCE.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a voice conference call

Copy link
MemberAuthor

@TrottTrottJul 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; I'll add that.

@Fishrock123
Copy link
Contributor

lgtm minus nits

Trott added 3 commits July 14, 2016 13:41
Update some outdated material. Provide some minor fixes. Wrap to 80 characters.
@mhdawson
Copy link
Member

LGTM

@Trott
Copy link
MemberAuthor

@nodejs/ctc Would be great to get some more LGTMs on this from CTC folks so I can land it in good conscience rather than putting it on the agenda for the next meeting. I imagine the other proposed changes might still need to go to the CTC meeting, but these seem mostly uncontroversial...

@misterdjules
Copy link

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

LGTM

@ofrobots
Copy link
Contributor

LGTM

@evanlucas
Copy link
Contributor

LGTM

@indutny
Copy link
Member

indutny commented Jul 18, 2016

LGTM/ЛГТМ

@ChALkeR
Copy link
Member

LGTM

1 similar comment
@trevnorris
Copy link
Contributor

LGTM

@Trott
Copy link
MemberAuthor

11 LGTMs plus me = 12 CTC folks in favor (out of 18), none opposed...

... Landed in 4ae24e1

@TrottTrott closed this Jul 19, 2016
Trott added a commit that referenced this pull request Jul 19, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
@evanlucasevanlucas mentioned this pull request Jul 19, 2016
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
@TrottTrott deleted the jointly branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

14 participants

@Trott@rvagg@bnoordhuis@Fishrock123@mhdawson@misterdjules@cjihrig@ofrobots@evanlucas@indutny@ChALkeR@trevnorris@vsemozhetbyt@MylesBorins