build: don't link against liblog on host system#7762
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnoordhuis added build 
Member
addaleax commented Jul 27, 2016
LGTM |
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: nodejs#7731 PR-URL: nodejs#7762 Reviewed-By: Anna Henningsen <[email protected]>
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: #7731 PR-URL: #7762 Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: #7731 PR-URL: #7762 Reviewed-By: Anna Henningsen <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: #7731 PR-URL: #7762 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: #7731 PR-URL: #7762 Reviewed-By: Anna Henningsen <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't link binaries that run on the host system against liblog, it
breaks cross-compiling for android.
Fixes: #7731 (note to self: link in commit log is wrong, fix before landing)
CI: https://ci.nodejs.org/job/node-test-pull-request/3315/