test: ensure callback runs in test-vm-sigint#7768
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added vm 
MemberAuthor
Trott commented Jul 16, 2016
Member
addaleax commented Jul 16, 2016
LGTM, thanks |
Contributor
Minor nit, but perhaps s/insure/ensure/ in the commit message? |
Member
addaleax commented Jul 16, 2016
The test failed on FreeBSD with no change in symptoms: https://ci.nodejs.org/job/node-test-commit-freebsd/3322/nodes=freebsd10-64/tapTestReport/test.tap-1066/ |
Contributor
cjihrig commented Jul 16, 2016
LGTM even if the test is not ultimately fixed. |
MemberAuthor
Trott commented Jul 19, 2016
@mscdex s/insure/ensure/ done |
mscdex changed the title MemberAuthor
Trott commented Jul 19, 2016
@addaleax Still looks good to you even though it doesn't fix the test? (I still think it's a minor improvement but I don't want to make assumptions that anyone agrees with that.) |
Member
addaleax commented Jul 19, 2016
Yep, I never expected this to fix the test in the first place. :) |
Trott added a commit to Trott/io.js that referenced this pull request Jul 20, 2016
PR-URL: nodejs#7768 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Jul 20, 2016
Landed in fd02c93 |
evanlucas pushed a commit that referenced this pull request Jul 21, 2016
PR-URL: #7768 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test vm
Description of change
Make sure the child process
closecallback runs exactly one time./cc @addaleax