src: Only use the TR1 type_traits when targeting OSX<10.9#7778
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
Member
bnoordhuis commented Jul 18, 2016
LGTM but can you make sure the first line of the commit log is <= 50 characters? |
Contributor
cjihrig commented Jul 18, 2016
LGTM |
Mac OSX 10.9 has switched to using libc++ by default. libc++ provides a C++11 <type_traits> implementation, so we only need to use the TR1 version when targetting OSX 10.8 or 10.7.
Author
ehsan commented Jul 21, 2016
Done! |
Member
bnoordhuis commented Jul 22, 2016
Member
addaleax commented Jul 27, 2016
LGTM and CI was green, landing… |
Member
addaleax commented Jul 27, 2016
Landed in 34d58ce, thanks! |
addaleax pushed a commit that referenced this pull request Jul 27, 2016
Mac OSX 10.9 has switched to using libc++ by default. libc++ provides a C++11 <type_traits> implementation, so we only need to use the TR1 version when targetting OSX 10.8 or 10.7. PR-URL: #7778 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Mac OSX 10.9 has switched to using libc++ by default. libc++ provides a C++11 <type_traits> implementation, so we only need to use the TR1 version when targetting OSX 10.8 or 10.7. PR-URL: #7778 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Contributor
MylesBorins commented Sep 30, 2016
this is not landing cleanly and blocked by some other util changes that I believe start with #6734 /cc @bnoordhuis |
Member
bnoordhuis commented Oct 2, 2016
I won't object to someone back-porting this patch but it's not necessary for v4.x releases, they are built with |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Mac OSX 10.9 has switched to using libc++ by default. libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.
This patch fixes build failures when using
-mmacosx-version-min=10.9to build Node.