doc: make general improvements to Buffer docs#7784
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mscdex added buffer 
mscdex commented Jul 18, 2016
/cc @nodejs/documentation |
silverwind commented Jul 19, 2016
Darn you, GitHub. @mscdex would you mind splitting up in two or more logical commits so we can do inline review? |
mscdex commented Jul 19, 2016
@silverwind Done. |
mscdex commented Jul 20, 2016
/cc @nodejs/collaborators |
doc/api/buffer.md Outdated
trevnorris commented Jul 20, 2016
Made it about half way through tonight. Awesome work. |
jasnell commented Jul 20, 2016
Woo! LGTM |
doc/api/buffer.md Outdated
There was a problem hiding this comment.
Do we really want this "floor of ... divided by two" here? Looks like condition doesn't change if we remove it, Buffer.poolSize >> 1 is rather computation optimization than something users should be aware of.
For example, if Buffer.poolSize would be equal to 3, both conditions size is less than or equal to Buffer.poolSize >> 1 (floor of Buffer.poolSize divided by two) (size <= 1) and size is less than or equal to Buffer.poolSize divided by two (size <= 1.5) are equal for any integer size.
Or do we explicitly want to specify behavior for cases when floating number is passed as a size?
trevnorris commented Jul 20, 2016
Thanks for the changes. LGTM |
PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
This commit adds more links and separates internal doc links from external web links. PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
This commit adds more links and reuses existing link references more. PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
This commit adds more links and separates internal doc links from external web links. PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
This commit adds more links and reuses existing link references more. PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #7784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins commented Sep 30, 2016
@mscdex I'm going to pass on landing this due to it being such a big change, and not being 100% if it aligns to the v4.x implementation of buffer. Please feel free to backport |
9 participants
Checklist
Affected core subsystem(s)
Description of change