Skip to content

Conversation

@lpinca
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jul 21, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be v0.1.33.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, I'll fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's actually v0.1.26.

@mscdex
Copy link
Contributor

mscdex commented Jul 21, 2016

EventEmitter.listenerCount is missing metadata. It was added in v0.9.12. Deprecated in v4.0.0.

EventEmitter.defaultMaxListeners is also missing metadata. It was added in v0.11.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to add that there should also be: deprecated: v4.0.0

@mscdex
Copy link
Contributor

LGTM

@lpinca
Copy link
MemberAuthor

I missed quite a few things, thanks for reviewing @mscdex.

@jasnell
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Aug 5, 2016
PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
@jasnell
Copy link
Member

Landed in 769f63c

@jasnelljasnell closed this Aug 5, 2016
@lpincalpinca deleted the add/added-events branch August 6, 2016 05:04
@cjihrigcjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
@MylesBorins
Copy link
Contributor

This is not backporting to v4.x cleanly. Please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
PR-URL: nodejs#7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
Ref: #8879 PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Ref: #8879 PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Ref: #8879 PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Ref: #8879 PR-URL: #7822 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca@mscdex@jasnell@MylesBorins@nodejs-github-bot