test: use common platform helpers everywhere#7845
Uh oh!
There was an error while loading. Please reload this page.
Conversation
test/parallel/test-setproctitle.js Outdated
There was a problem hiding this comment.
This might be more readable as !(common.isFreeBSD || common.isOSX || common.isLinux)
cjihrig commented Jul 22, 2016
LGTM with a couple comments. |
santigimeno commented Jul 22, 2016
santigimeno commented Jul 22, 2016
PR updated. Thanks |
cjihrig commented Jul 23, 2016
CI came back all green. I wonder if the |
bnoordhuis commented Jul 23, 2016
LGTM
The way I read it, the test was simply always skipped on all platforms. |
jasnell commented Jul 26, 2016
LGTM |
santigimeno commented Jul 26, 2016
@cjihrig, after Ben's explanation, does the PR LGTY? |
cjihrig commented Jul 26, 2016
@santigimeno yes. I think we were saying the same thing... I just said it wrong. |
santigimeno commented Jul 27, 2016
Use the common.isWindows, common.isFreeBSD and common.isSunOS where possible. Add common.isOSX and common.isLinux. Fix `test-fs-read-file-sync-hostname` as in its current form was not being run anywhere. PR-URL: nodejs#7845 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
santigimeno commented Jul 27, 2016
All green except a known |
santigimeno commented Jul 27, 2016
Landed in dee0e3a |
Use the common.isWindows, common.isFreeBSD and common.isSunOS where possible. Add common.isOSX and common.isLinux. Fix `test-fs-read-file-sync-hostname` as in its current form was not being run anywhere. PR-URL: #7845 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Use the
common.isWindows,common.isFreeBSDandcommon.isSunOSwhere possible. Addcommon.isOSXandcommon.isLinux.Fix
test-fs-read-file-sync-hostnameas in its current form was not being run anywhere./cc @nodejs/testing