Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: remove extra space in console.log examples#7885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
joeyespo commented Jul 27, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
mscdex commented Jul 27, 2016
LGTM |
ChALkeR commented Jul 27, 2016
Could you fix the exact same issue in other doc files, please? |
joeyespo commented Jul 27, 2016
@ChALkeR Done! I amended the commit so there's still only one. |
addaleax commented Jul 27, 2016
LGTM |
ChALkeR commented Jul 27, 2016
@joeyespo Cool, thanks! That was an example, though. Full list: Ah, and LGTM either way. |
93df4ac to 7cdfa2eComparejoeyespo commented Jul 28, 2016 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@ChALkeR Ah, sorry, I misunderstood. Done! I amended the original commit with those. Rebased too. I also found a few more whitespace tweaks while making sure I got everything, along with the inverse of this fix ( I can squash them into one commit or split them out to a new PR if that's preferred. Let me know! |
doc/api/modules.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another whitespace at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there is nothing. It's the rendering on my phone that is wrong.
targos commented Jul 28, 2016
All changes LGTM. |
doc/api/process.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also fix the indention to 2 spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended.
03c9347 to 1fb2055Comparejoeyespo commented Jul 28, 2016
Ok. All comments are addressed. |
jasnell commented Jul 29, 2016
LGTM |
PR-URL: #7885 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell commented Jul 29, 2016
Landed in a single squashed commit... 6ea8c66 |
PR-URL: #7885 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #7885 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #7885 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #7885 Reviewed-By: Brian White <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
Affected core subsystem(s)
doc
Description of change
This fixes the
console.logexample in the docs. Before this change, an extra space would be printed, which wouldn't match the example output. Now it's consistent.