src: fix use-after-free in inspector agent#7907
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnoordhuis added c++ MemberAuthor
bnoordhuis commented Jul 28, 2016
bnoordhuisforce-pushed the v8-inspector-use-after-free branch from ef2e2dc to 4902a4aCompareMemberAuthor
bnoordhuis commented Aug 1, 2016
Rebased, PTAL. CI: https://ci.nodejs.org/job/node-test-pull-request/3482/ R=@ofrobots? |
Member
jasnell commented Aug 1, 2016
LGTM fwiw :-) |
Contributor
eugeneo commented Aug 1, 2016
Lgtm. Thanks! |
Contributor
ofrobots commented Aug 1, 2016
LGTM. |
uv_close() is an asynchronous operation. Calling it on a data member inside the destructor is unsound because its memory is about to be reclaimed but libuv is not done with it yet. PR-URL: nodejs#7907 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuisforce-pushed the v8-inspector-use-after-free branch from 4902a4a to 80b10b4Compare
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
uv_close() is an asynchronous operation. Calling it on a data member inside the destructor is unsound because its memory is about to be reclaimed but libuv is not done with it yet. PR-URL: #7907 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv_close() is an asynchronous operation. Calling it on a data member
inside the destructor is unsound because its memory is about to be
reclaimed but libuv is not done with it yet.
CI: https://ci.nodejs.org/job/node-test-pull-request/3445/