Skip to content

Conversation

@ravindrabarthwal
Copy link
Contributor

@ravindrabarthwalravindrabarthwal commented Jul 29, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added missing semicolon

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 29, 2016
@mscdex
Copy link
Contributor

LGTM

3 similar comments
@JungMinu
Copy link
Member

LGTM

@jasnell
Copy link
Member

LGTM

@doron2402
Copy link

LGTM

@cjihrig
Copy link
Contributor

LGTM. Landed in 1658297. Thanks!

@cjihrigcjihrig closed this Aug 1, 2016
cjihrig pushed a commit that referenced this pull request Aug 1, 2016
PR-URL: #7915 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #7915 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #7915 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #7915 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #7915 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@ravindrabarthwal@mscdex@JungMinu@jasnell@doron2402@cjihrig@MylesBorins@nodejs-github-bot