Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Aug 1, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test util

Description of change

Test is currently failing intermittently on FreeBSD only.

Refs: #7919

@TrottTrott added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Aug 1, 2016
@Trott
Copy link
MemberAuthor

Trott commented Aug 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3475/

EDIT: Build failure on FreeBSD. Running this on FreeBSD is kind of important, I guess. Let's try again: https://ci.nodejs.org/job/node-test-pull-request/3476/

EDIT: Windows build failure that time. No tests on Windows seems like a bad way to go, even for a tiny change like this, so let's try another time: https://ci.nodejs.org/job/node-test-pull-request/3477/

@Trott
Copy link
MemberAuthor

Trott commented Aug 1, 2016

CI is green.

@jasnell
Copy link
Member

LGTM

@cjihrig
Copy link
Contributor

LGTM, but perhaps we should evaluate #7933 as a fix first.

@jasnell
Copy link
Member

Going to label this as blocked on #7933 for the time being then.

@jasnelljasnell added the blocked PRs that are blocked by other issues or PRs. label Aug 4, 2016
@Trott
Copy link
MemberAuthor

Trott commented Aug 4, 2016

It is not blocked by that PR. It can land immediately. But if that PR lands first, then this becomes unnecessary.

@TrottTrott removed the blocked PRs that are blocked by other issues or PRs. label Aug 4, 2016
@addaleax
Copy link
Member

Closing this because #7933 landed. :)

@TrottTrott deleted the freebsd-status branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to the tests.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@jasnell@cjihrig@addaleax