doc: add @addaleax to the CTC#7966
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Voted on and approved at CTC meeting nodejs#7948 (2016-08-03).
Contributor
evanlucas commented Aug 3, 2016
LGTM |
1 similar comment
Contributor
cjihrig commented Aug 3, 2016
LGTM |
Member
bnoordhuis commented Aug 3, 2016
There goes my top spot... LGTM. Welcome, Anna. |
Member
jasnell commented Aug 3, 2016
LGTM!! |
Member
jasnell commented Aug 3, 2016
I'm gonna go out on a limb and say this one doesn't need to wait 48/72 hours to land. The CTC approved the nomination today and @addaleax is now a CTC member. Woot! |
jasnell pushed a commit that referenced this pull request Aug 3, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
addaleax commented Aug 3, 2016
Member
jasnell commented Aug 3, 2016
Yes! I just hadn't gotten back to the UI to do so :-D |
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Voted on and approved at CTC meeting #7948 (2016-08-03). PR-URL: #7966 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure there’s a fixed process for this (or if so, I couldn’t find it/tell from the previous CTC changes), so… I guess here I am?