Skip to content

Conversation

@joshgav
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

tools?

Description of change

Add .vscode/ to .gitignore to make it easier to work on Node in VS Code.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 3, 2016
@addaleax
Copy link
Member

LGTM (judging from the git history, gitignore: would be fine, too)

@jasnell
Copy link
Member

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

LGTM

@JacksonTian
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Aug 5, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
@jasnell
Copy link
Member

Landed in 1e1bbe5!

@jasnelljasnell closed this Aug 5, 2016
@joshgavjoshgav deleted the gitignore-vscode branch August 5, 2016 19:58
@cjihrigcjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #7967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joshgav@addaleax@jasnell@cjihrig@JacksonTian@MylesBorins@nodejs-github-bot