repl: disable Ctrl+C support on win32 for now#7977
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: nodejs#7837
addaleax added repl 
jasnell commented Aug 4, 2016
Oy, this is unfortunate but LGTM as a temporary measure. /cc @nodejs/platform-windows |
seishun commented Aug 4, 2016
LGTM |
1 similar comment
cjihrig commented Aug 4, 2016
LGTM |
joaocgreis commented Aug 4, 2016
LGTM, thanks for the env var! |
jasnell commented Aug 4, 2016
oh! mentioning the env var reminded me... is the intent to keep the env var undocumented and temporary as well? If not, then this should also add documentation to printHelp and docs. |
addaleax commented Aug 4, 2016
@jasnell No, keeping it uncodumented is exactly the plan (or at least what I am having in mind). I thought about getting fancy with underscores or something, but that just seemed weird for env vars. |
jasnell commented Aug 4, 2016
+1 awesome. That's what I suspected but wanted to clarify. It may be worthwhile adding a code comment to that effect in case someone else comes across it and wonders. |
addaleax commented Aug 4, 2016
@jasnell Done! :) |
jasnell commented Aug 4, 2016
Thank you! :-) |
jasnell commented Aug 8, 2016
New CI run just to be safe: https://ci.nodejs.org/job/node-test-pull-request/3571/ |
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: #7837 PR-URL: #7977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: João Reis <[email protected]>
jasnell commented Aug 8, 2016
Landed in f59b888! |
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: #7837 PR-URL: #7977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: João Reis <[email protected]>
MylesBorins commented Sep 30, 2016
@addaleax does this need to be backported? |
addaleax commented Sep 30, 2016
No. :) |
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of
evaluated expressions.
This is a temporary measure, since the underlying problem is very likely not related to this specific feature.
Ref: #7837
/cc @joaocgreis