lib: remove double check#7985
Closed
lib: remove double check #7985
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
checkIsHttpToken() already checks for typeof string. We do not want to check twice.
Member
bnoordhuis commented Aug 5, 2016
LGTM |
Member
addaleax commented Aug 5, 2016
Contributor
cjihrig commented Aug 5, 2016
LGTM. CI is green. |
Member
jbergstroem commented Aug 5, 2016
LGTM |
Contributor
mscdex commented Aug 5, 2016
The commit message should target |
Member
jasnell commented Aug 5, 2016
LGTM. although this removes an error, it's one that should have already been hidden by the other check, so this wouldn't be a semver-major at all... +1! |
jasnell pushed a commit that referenced this pull request Aug 8, 2016
checkIsHttpToken() already checks for typeof string. We do not want to check twice. PR-URL: #7985 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Aug 8, 2016
Landed in 35109dd! |
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
checkIsHttpToken() already checks for typeof string. We do not want to check twice. PR-URL: #7985 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
lib
Description of change
checkIsHttpToken() already checks for typeof string. We do not
want to check twice.